This repository has been archived by the owner on Dec 18, 2021. It is now read-only.
respect MVNW_VERBOSE when printing diagnostic stuff #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttddyy
reviewed
Oct 19, 2017
| * @author <a href="mailto:konstantin.sobolev@gmail.com">Konstantin Sobolev</a> | ||
| */ | ||
| public class Logger { | ||
| private static final boolean VERBOSE = "true".equalsIgnoreCase(MavenWrapperMain.MVNW_VERBOSE); |
There was a problem hiding this comment.
Hey,
I'm not completely agree with the suggestion, but just looking the PR, this line seems wrong.
It is referencing a string.
Either here or MavenWrapperMain.MVNW_VEREBOSE needs to check the value from system env.
There was a problem hiding this comment.
Oops, my bad, you're right. Updated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvnw shouldn't print anything on the screen unless explicitly asked for, otherwise it breaks scripts that expect no extra output when running
mvnw --quiet