This repository has been archived by the owner on Dec 18, 2021. It is now read-only.
Support authentication on artifacts download location #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdotjansen
commented
Aug 20, 2018
| elif command -v curl > /dev/null; then | ||
| if [ "$MVNW_VERBOSE" = true ]; then | ||
| echo "Found curl ... using curl" | ||
| fi | ||
| curl -o "$wrapperJarPath" "$jarUrl" | ||
| if [ -z "$MVNW_WRAPPER_AUTH_USERNAME" ] || [ -z "$MVNW_WRAPPER_AUTH_PASSWORD" ]; then | ||
| curl -o "$wrapperJarPath" "$jarUrl" -f |
There was a problem hiding this comment.
Added -f to not create a file when the http status is not correct (in my example 401).
|
I could really use this feature for our company. Here is my upvote! |
|
Could you resolve the conflict so we get this working with TLS 1.2 on Windows (I cant test or develop this on Windows. Also could you simplify the property names to just MVNW_USERNAME and MVNW_PASSWORD? Last but not least... does this basically replace #96 .. it seems like this is a much more complete implementation. Am I right or am I missing something? |
|
Once the above items are covered I am hoping to cut a new release soon. |
… takari-master # Conflicts: # mvnw.cmd
Merged
isopov
pushed a commit
to isopov/maven-wrapper
that referenced
this pull request
Jul 30, 2019
Support authentication on artifacts download location
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many servers cannot access the internet directly. I would like our ci server to be able to use mvnw. We use a maven repository (artifactory) to cache and validate artifacts we download. our artifactory is password protected and has different rights based on the users. I have added authentication based on environment variables as including the username and password in the URL would exposes our user and password with way too much rights.