Rails 6.1 Compatability #32
Conversation
The DepthFirst visitor got removed from Arel [0]. This inlines a very simple depth first traversal to cover the needs of the join condition column "listing" without relying on the removed DepthFirst visitor. [0] https://github.com/rails/rails/pull/36492/files
|
We're using this in production, now. |
|
I can confirm this PR is working fine for me with Rails 6.1. Thanks @walski |
|
Is there a particular reason this hasn't been merged? |
|
@zachaysan you mind taking a look at this? Blocking 6.1 upgrade for us. |
|
@travisofthenorth, @walski and everyone else: I'm very sorry, I was hospitalized and in otherwise poor health for months and this slipped. I'll merge and cut a gem for this now. Thank you very much for bringing it to my attention. |
|
@travisofthenorth I've pushed the gem to rubygems, let me know if you have any trouble. https://rubygems.org/gems/activerecord-hierarchical_query/versions/1.3.0 |
|
@zachaysan no worries. Thank you so much for the quick turnaround! |
|
@travisofthenorth it's the least I could do. I should investigate getting another maintainer in the event that this happens again, as my medical condition, while fine for now, could reappear. If you or @walski have any interest let me know. |
This allows working with Rails 6.1 RC1.