Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: "environment" nomenclature in the documentation is confusing #47

Closed
brindy opened this issue Sep 15, 2018 · 1 comment
Closed
Assignees

Comments

@brindy
Copy link

brindy commented Sep 15, 2018

For me an environment is "production", "staging", etc.

When I ran takeoff init <env> I was expecting it to be structured in a way that reflected this and allow me to add alternative environments based on the same overall source code, but it seems to be more of a "workspace", ie a collection of projects and configuration.

Further more, the Angular app itself appears to talk about environments, including the code:

if (environment.production) {
  enableProdMode();
}

Have I misunderstood the intention or would an alternative name (like "workspace") be more appropriate?

@tanepiper
Copy link
Collaborator

@brindy Yes, I agree I didn't always like that name - workspace does sound better. Naming is hard :)

@tanepiper tanepiper self-assigned this Sep 17, 2018
tanepiper added a commit that referenced this issue Sep 18, 2018
* Remove } from folder name. Fixes #46
* Fail fast on dependencies, fixes #45
* Update doc references for environment to workspace. Fixes #47
* Improve types exporting and docs for public api
* Clean up exit with message interface
* RC File properties are now a map
* Support custom project dependencies in the `.takeoffrc` file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants