トップページのデザイン変更 #89
Merged
トップページのデザイン変更 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
以下の各ブラウザで崩れないことを確認しました。
以下のブラウザでは崩れるようです。
|
takeyuweb
requested changes
Feb 13, 2019
itkrt2y
force-pushed
the
feature/top-page-design
branch
from
0fe4534
to
f18c9ba
Compare
|
flexboxの都合上、projectsの個数によっては以下の画像のように最後の行は変な配置されますが、「POPULAR PROJECTS のプロジェクトを10個までにする」とかはもう10個固定にして対応ってことでいいのでしょうか？
|
はい、今回はトップ10決め打ちでいいので、数が半端になったときのことは考慮しないことにします。 |
|
@takeyuweb iPad でのレイアウト崩れを修正しました。 |
itkrt2y
force-pushed
the
feature/top-page-design
branch
from
221124b
to
df50986
Compare
itkrt2y
force-pushed
the
feature/top-page-design
branch
from
df50986
to
3faa7fb
Compare
|
他の作業の兼ね合いもあるので、とりあえずマージしちゃいます。まだ問題があれば別PRで |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
データの埋め込みはまだなので、どなたかお願いします。
【データがまだ反映されていない箇所】