✨ Add the external option

takker99 · Nov 11, 2021 · 00fde6d · 00fde6d
1 parent 0ac3d48
commit 00fde6d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/loader.ts b/loader.ts
@@ -69,18 +69,18 @@ export const remoteLoader = (
       ({ path, importer }) => {
         if (skip(path)) return { external: true };
         const resolvedPath = importMap.imports?.[path] ?? path;
-        if (skip(path)) return { external: true };
+        if (skip(resolvedPath)) return { external: true };
 
         if (resolvedPath.startsWith("http")) {
-          console.log(`(${path}, ${importer}) -> ${resolvedPath}`);
+          console.log(`(${path}) -> ${resolvedPath}`);
           return {
             path: decodeURI(resolvedPath),
             namespace: name,
           };
         }
         importer = importer === "<stdin>" ? baseURL.toString() : importer;
         const importURL = new URL(resolvedPath, importer).toString();
-        if (skip(path)) return { external: true };
+        if (skip(importURL)) return { external: true };
         if (importURL.startsWith("http")) {
           console.log(`(${resolvedPath}, ${importer}) -> ${importURL}`);
           return {

diff --git a/parseParams.ts b/parseParams.ts
@@ -17,13 +17,15 @@ export function parseSearchParams(searchParam: string): ParamOptions {
   const entryURL = params.get("url") ?? "";
   const reload = params.get("reload") === null ? false : true;
   const sourcemap = params.get("sourcemap") === null ? false : "inline";
+  const external = params.getAll("external");
 
   return {
     bundle,
     minify,
     format: isFormat(format) ? format : "esm",
     charset,
     entryURL,
+    external,
     run,
     jsxFactory,
     jsxFragment,

diff --git a/types.ts b/types.ts
@@ -37,6 +37,7 @@ export type BundleOptions = {
   charset?: "utf8";
   format: Format;
   entryURL: string;
+  external: string[];
   jsxFactory: string;
   jsxFragment: string;
   reload: boolean;