Fix syntax error to enable support for python 3.5 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since clients of juptyer_server will need to support py3.5, we should to do the same given JKM's primary application will be jupyter_server. This change fixes the syntax error and adds 3.5 to test matrices.
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 71.43% 71.43%
=======================================
Files 29 29
Lines 2048 2048
=======================================
Hits 1463 1463
Misses 585 585
Continue to review full report at Codecov.
|
Closed
|
I went ahead and merged this so we could get 0.5.1 out. Not sure how long we'll need to support python 3.5, but at least this checks off a box for moving forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since clients of juptyer_server will need to support py3.5, we should
to do the same given JKM's primary application will be jupyter_server.
This change fixes the syntax error and adds 3.5 to test matrices.