Getmessage n1 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkumohikan
force-pushed
the
getmessageN1
branch
from
74891db
to
5125aa3
Compare
|
|
|
|
|
|
|
mism-mism
reviewed
Aug 30, 2020
app/src/isubata/app.go
Outdated
| } | ||
|
|
||
| users := []User{} | ||
| sql := "SELECT name, display_name, avatar_icon FROM user WHERE id in (?)" |
There was a problem hiding this comment.
messages := []MessageWithUser{}
err = db.Select(&messages, "select m.id, m.content, m.created_at, u.name, u.display_name, u.avatar_icon from message m inner join user u on u.id = m.user_id where m.id > ? and m.channel_id = ? order by m.id desc limit 100", lastID, chanID)
if err != nil {
return err
}
response := make([]map[string]interface{}, 0)
for i := len(messages) - 1; i >= 0; i-- {
m := messages[i]
r := make(map[string]interface{})
r["id"] = m.ID
r["user"] = User{
Name: m.UserName,
DisplayName: m.UserDisplayName,
AvatarIcon: m.UserAvatarIcon,
}
r["date"] = m.CreatedAt.Format("2006/01/02 15:04:05")
r["content"] = m.Content
response = append(response, r)
}
pinkumohikan
force-pushed
the
getmessageN1
branch
from
418a187
to
bba74f5
Compare
|
Closed
app/src/isubata/app.go
Outdated
| sql := "SELECT * FROM user WHERE id in (?)" | ||
| sql, params, err := sqlx.In(sql, uids) | ||
| if err != nil { | ||
| log.Fatal(err) |
app/src/isubata/app.go
Outdated
|
|
||
| users := []User{} | ||
| if len(uids) != 0 { | ||
| sql := "SELECT * FROM user WHERE id in (?)" |
There was a problem hiding this comment.
sqlはパッケージ名とコンフリクトするんで、回避しといたほうがヨシ
|
コード的にはよさそうっす |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1