Fix Windows build when UNICODE macro is specified. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When UNICODE macro is specified, CreateFile is mapped to CreateFileW rather than CreateFileA, which results in a build error due to incompatible types. We can support both cases by using CreateFileA explicitly.
taku910
added a commit
that referenced
this pull request
May 8, 2015
Fix Windows build when UNICODE macro is specified.
yukawa
added a commit
to google/mozc
that referenced
this pull request
Sep 19, 2015
With following commits, we can now build Zinnia from source even on Windows and Ubuntu 14.04. - taku910/zinnia#2 - taku910/zinnia#3 - taku910/zinnia#4 Thus we don't need to conditionally disable Zinnia only on Windows anymore. '--use_zinnia' option in build_mozc.py can also be removed. To simplify the DEPS rule and improve the code/test coverage this CL also updates gyp/common.gypi so that Zinnia will be compiled from source even on Linux by default. Users and packagers are still able to use system-installed Zinnia by manually specifying following GYP_DEFINES environment variable as follows. GYP_DEFINES="use_libzinnia=1". With this CL, we no longer need subversion to check out OSS Mozc. Closes #299. No user-visible behavior change is intended with this CL. BUG=#299 TEST=unittest REF_BUG=6443612,23909405 REF_CL=102630042,103073294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When UNICODE macro is specified, CreateFile is mapped to
CreateFileW rather than CreateFileA, which results in a
build error due to incompatible types.
We can support both cases by using CreateFileA explicitly.