Fix metrics save frequency

takuseno · Jan 28, 2021 · b6c9b69 · b6c9b69
1 parent 0d91df6
commit b6c9b69
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/d3rlpy/online/iterators.py b/d3rlpy/online/iterators.py
@@ -253,9 +253,10 @@ def train_single_env(
             if eval_scorer:
                 logger.add_metric("evaluation", eval_scorer(algo))
 
+        # save metrics
+        logger.commit(epoch, total_step)
+
         if epoch % save_interval == 0:
-            # save metrics
-            logger.commit(epoch, total_step)
             logger.save_model(total_step, algo)
 
 
@@ -424,9 +425,10 @@ def train_batch_env(
             if eval_scorer:
                 logger.add_metric("evaluation", eval_scorer(algo))
 
+        # save metrics
+        logger.commit(epoch, total_step)
+
         if epoch % save_interval == 0:
-            # save metrics
-            logger.commit(epoch, total_step)
             logger.save_model(total_step, algo)
 
     # finish all process