Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Support for additional OPE algorithms #231

Open
LXYTSOS opened this issue Oct 17, 2022 · 4 comments
Open

[REQUEST] Support for additional OPE algorithms #231

LXYTSOS opened this issue Oct 17, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@LXYTSOS
Copy link

LXYTSOS commented Oct 17, 2022

Support for additional OPE algorithms such as weighted importance sampling, doubly robust.

@LXYTSOS LXYTSOS added the enhancement New feature or request label Oct 17, 2022
@pathway
Copy link

pathway commented Oct 17, 2022

Gawd yes please

@takuseno
Copy link
Owner

@LXYTSOS Thank you for the issue! Those should definitely be supported for the practical usecases. I'll consider this feature in the following updates.

@paulhilders
Copy link

@takuseno This would be a very useful addition to an already amazing library! Do you maybe have an indication of when these features might be added?

@joshuaspear
Copy link
Contributor

joshuaspear commented Jun 16, 2023

Hey - I have started creating an ope library for offline RL which includes an api for d3rlpy. It's not fully tested yet but I have included regression (weighted importance sampling). I have also included functionality to have ope methods as scorers when calling LearnableBase.fit in d3rlpy. However, this relies on an epoch callback functionality that I have implemented in the following PR (#286). Feedback and contributions are more than welcome :)

https://github.com/joshuaspear/offline_rl_ope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants