Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epoch callback for offline .fit method #286

Merged
merged 6 commits into from
Jun 23, 2023
Merged

Conversation

joshuaspear
Copy link
Contributor

Added callback post epoch to the LearnableBase fit method

@joshuaspear
Copy link
Contributor Author

@takuseno, looks like the CI/CD checks are failing due to a failure to import numpy. Any thoughts on this sorry?

Copy link
Owner

@takuseno takuseno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I see some coding style issues. Can you try this?

pip install black==22.3.0 yapf isort
./scripts/format

d3rlpy/base.py Outdated Show resolved Hide resolved
@joshuaspear
Copy link
Contributor Author

@takuseno I've run the formatting scripts - sorry for missing that! The github action still seems to be failing. Just looking at similar issues (https://stackoverflow.com/questions/60180802/github-python-action-failing-on-numpy) and the .github actions, I wonder if it's worth explicitely pip installing numpy for the format check and macos build? Really not familiar with this kind of stuff so might be barking up the wrong tree!

@takuseno
Copy link
Owner

Thanks for the update! It seems that there is an issue in CI side. But, I locally checked your branch and confirmed it's okay. So let me merge this PR. Thank you for your contribution!

Note that the next major update is under development in nightly branch.

@takuseno takuseno merged commit d5992b5 into takuseno:master Jun 23, 2023
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants