This repository has been archived by the owner on Sep 26, 2022. It is now read-only.
Avoid hardcoded strings #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigspider
force-pushed
the
173-hardcoded-strings
branch
from
aeddc7a
to
c1811f4
Compare
sr-gi
suggested changes
Sep 16, 2020
common/appointment.py
Outdated
| @@ -1,4 +1,13 @@ | |||
| import struct | |||
There was a problem hiding this comment.
Removed from both here and test/common/unit/test_appointment.py.
bigspider
force-pushed
the
173-hardcoded-strings
branch
from
c1811f4
to
2d35bb9
Compare
…ed strings; fix wrong docs in api.py for get_appointment; fixed few typos in docs
bigspider
force-pushed
the
173-hardcoded-strings
branch
from
2d35bb9
to
3e0bb3c
Compare
sr-gi
approved these changes
Sep 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an AppointmentStatus Enum for the possible appointment statuses, and a class constant for the "END" message of the ChainMonitor.
A larger refactoring in the same spirit could make sense for the config dictionary keys, but it is not trivial because of the need of making it work with
config_loader.py.Also fixing a few documentation errors and typos
Closes: 173