Makes Tor task panics more user friendly #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does |
I've manually tested and looks like it does. std::process::exit terminates the current process, so I would assume so. |
|
Any tACK? @booklearner @meryacine Cannot make unit tests for this so manual testing would be appreviated |
booklearner
approved these changes
Aug 26, 2022
mariocynicys
approved these changes
Aug 26, 2022
|
ah, TIL tACK = test ACK - sorry for the premature approval 😅 |
|
@booklearner np np, we're all learning here 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given we cannot address #57 atm, lets at least make it so if the Tor thread fails it does so in a more user friendly way.