Upgrade to badger/v3 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocassetti
reviewed
Jun 22, 2021
| @@ -14,7 +14,7 @@ import ( | |||
| "sync/atomic" | |||
| "time" | |||
|
|
|||
| "github.com/dgraph-io/badger/v2" | |||
| "github.com/dgraph-io/badger/v3" | |||
There was a problem hiding this comment.
Will it auto upgrade a v2 database on opening?
There was a problem hiding this comment.
I'm not sure, haven't tried. I would also like @qiaowei-g to review the options. There's many changes in badger and apparently they are using manual memory allocation to use a bit less memory and free it better.
There was a problem hiding this comment.
based on the description in badger-#1555, v2 data cannot be read by v3, so we will have to handle the deployment carefully to ensure no data loss.
There was a problem hiding this comment.
Alright, I'll mark it as 1.3 release so we don't mix things up.
qiaowei-g
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades to
badger/v3which has a lot of memory-related changes under the hood. See https://github.com/dgraph-io/badger/blob/master/CHANGELOG.mdNoteworthy PRs: