Job Postings Expiration Date #615
Conversation
| `${API_URL}/redUsers/${userId}/tpJobListings?filter=${JSON.stringify({ | ||
| where: { | ||
| expiresAt: { lt: currentDate }, | ||
| }, |
There was a problem hiding this comment.
I am testing this PR on my local and see neither active nor expired job postings. Not sure if the problem is here, but it seems that fetching job listings returns undefined.
.../redi-talent-pool/src/components/organisms/company-profile-editables/EditableJobPostings.tsx
Outdated
Show resolved
Hide resolved
| <div | ||
| style={{ | ||
| backgroundImage: `url(${JobPlaceholderCardUrl})`, | ||
| backgroundRepeat: 'x-repeat', | ||
| backgroundSize: 'contain', | ||
| height: '13rem', | ||
| width: '100%', | ||
| display: 'flex', | ||
| alignItems: 'center', | ||
| justifyContent: 'center', | ||
| }} | ||
| ></div> |
There was a problem hiding this comment.
Big copy n' paste. How about we create a nice n' named component? (just putting it below this one)
There was a problem hiding this comment.
I didn't really understand this comment. What do you mean by copy paste? Can you tell me where it's copy pasted from so I can make them both a nice component?
There was a problem hiding this comment.
If you look at line 103 in the same file (and in the same function/component) you'll see some repetition. That, plus the fact that this component has grown quite large now, is for me reason for a quick refactor into a well-named component so we also clearly know what this div block is.
…ob-posting-expiration-date
…ob-posting-expiration-date
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 753993 | Generic High Entropy Secret | b3e7f20 | nx.json | View secret |
| 753993 | Generic High Entropy Secret | ad5445b | nx.json | View secret |
| 753993 | Generic High Entropy Secret | 863d333 | nx.json | View secret |
| 753993 | Generic High Entropy Secret | e7ef109 | nx.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
What should the reviewer know?