Skip to content

Commit

Permalink
Merged in changes from Penumbear: Fixed a bug related to the animatio…
Browse files Browse the repository at this point in the history 
…n duration and durations between keyframes; Added better support for retina; A few performance improvements; Cleaned up the code a bit and added additional comments; Added hooks for subclasses so you can create custom behavior on frame change and animation completion; Added a playback speed property; Added support for scale x and scale y properties; Fixed a bug related to rotation interpolation and spin.
  • Loading branch information
@talentless
talentless committed Oct 2, 2012
1 parent 59d65db commit 64c49b8
Show file tree
Hide file tree
Showing 7 changed files with 389 additions and 379 deletions.

1 comment on commit 64c49b8

@jessiqiu111
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I am using your implementation that is so so useful to me. But I met several problems here:1.You assumed the nextFrameTimeLine and currentFrameTimeline were the same one, while sometimes they are different.So in my project I add these code as below:
"TGSpriterTimeline * nextTimeline = [curAnimation_.timelines objectAtIndex:[nextObjectRef timelineId]];"
and modified this line:
"TGSpriterTimelineKey * nextTimelineKey = [nextTimeline.keys objectAtIndex:[nextObjectRef timelineKey]];"
2.when nextFrameTimeLine and currentFrameTimeline are different, I think we cannot simply use the interpolate formula in it. So I added "if[curObjectRef timelineId] == [nextObjectRef timelineId])" before imterpolate.
3.When I set smoothTransition YES, it doesn't work well, yet I couldn't fix it. Hope you could make it better.
Thanks again for your job which helped me a lot.

Please sign in to comment.