Educate for pk management

talentprotocol · May 6, 2024 · 8e77df8 · 8e77df8
1 parent d6eb2e1
commit 8e77df8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -5,7 +5,7 @@ on:
     branches:
       - master
     tags:
-      - '*'
+      - "*"
   pull_request:
     types: [opened, synchronize]
 
@@ -16,12 +16,13 @@ jobs:
 
     env:
       FORCE_COLOR: true
+      PRIVATE_KEY: ${{secrets.PRIVATE_KEY}}
 
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
-          node-version: '16'
+          node-version: "16"
 
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path

diff --git a/hardhat.config.ts b/hardhat.config.ts
@@ -14,11 +14,8 @@ dotenv.config();
 
 import type { HardhatUserConfig } from "hardhat/config";
 
-const deployer = {
-  mnemonic: process.env.MNEMONIC || "test test test test test test test test test test test junk",
-};
-
-// const deployer = [""];
+// Never hardcode a pk here. Use the .env file
+const deployer = [process.env.PRIVATE_KEY];
 
 task("accounts", "Prints the list of accounts", async (args, hre) => {
   const accounts = await hre.ethers.getSigners();
@@ -83,8 +80,8 @@ const config: HardhatUserConfig = {
       alfajores: process.env.CELO_API_KEY || "",
       polygon: process.env.POLYGON_API_KEY || "",
       polygonMumbai: process.env.POLYGON_API_KEY || "",
-      base: "",
-      baseSepolia: "",
+      base: process.env.POLYGON_API_KEY || "",
+      baseSepolia: process.env.POLYGON_API_KEY || "",
     },
     // Custom chains that are not supported by default
     customChains: [