TGE Contracts #85
Merged
TGE Contracts #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francisco-leal
force-pushed
the
add-TGE-contracts
branch
from
a73c8c7
to
21216c7
Compare
rsmarques
reviewed
May 26, 2024
rsmarques
reviewed
May 26, 2024
| } | ||
|
|
||
| // Burn the equivalent amount of tokens for the missed weeks | ||
| uint256 amountToBurn = Math.min(WEEKLY_CLAIM_AMOUNT * weeksMissed, user.amountOwed); |
There was a problem hiding this comment.
weeksMissed here can be higher than MAX_CLAIM_WEEKS. Is it supposed to or should it be ceiled to 96?
There was a problem hiding this comment.
the logic is correct, if the user claims after MAX_CLAIM_WEEKS + 10, then more tokens should be burned than if it was claimed at the MAX_CLAIM_WEEKS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the scope of this work: https://talentprotocol.notion.site/Smart-Contracts-Audit-pre-TGE-0d27d984bc3c4dabaf49db3c31013c8b?pvs=4