"Error in !install_R : 'install_R' is missing" (install_R was called …

…in too early) - Fixed a bug in updateR, (thanks to AC for the bug report!)
talgalili · Mar 6, 2013 · 3baaf50 · 3baaf50
1 parent fa057fb
commit 3baaf50
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/NEWS b/NEWS
@@ -9,6 +9,7 @@ UPDATED FUNCTIONS:
 
 BUG FIXES:
    * Fixed a bug in updateR, to make sure it will be able to open the new Rgui, and also close the old R.
+   * Fixed a bug in updateR, "Error in !install_R : 'install_R' is missing" (install_R was called in too early) (thanks to AC for the bug report!)
 
 
 installR 0.8

diff --git a/R/updateR.r b/R/updateR.r
@@ -348,7 +348,7 @@ updateR <- function(browse_news, install_R, copy_packages, keep_old_packages,  u
 
    there_is_a_newer_version_of_R <- check.for.updates.R(print_R_versions)
 
-   if(!there_is_a_newer_version_of_R | !install_R) return(F) # if we have the latest version - we might as well stop now...
+   if(!there_is_a_newer_version_of_R) return(F) # if we have the latest version - we might as well stop now...
 
    # else - there_is_a_newer_version_of_R==T