Update the string concat method. Edit some error messages for clarity #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the method for string concatenation to new method (%s is deprecated). Also edit error messages for global English and clarity.
|
@weflower Thanks for the PR! I'm reviewing the code to see what changes are necessary with the current versions of the Plex server and clients. This PR required a manual merge for the develop branch, for now it's just the string substitution changes and will be looking at the error message wording changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the way strings are concatenated/constructed to use the new .format() method (or just "+" when it's simple enough). The %s method that was used is deprecated in newer releases of Python, so future proofing in case Plex upgrades at some point.
I also edited some error messages for global English and clarity.