feat: expose mongo service on internal nlb #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrliptontea
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
I was a bit confused at first cause nowhere it specifies that the NLB should be an internal one, but reading the docs I found that internal is the default.
I wonder if it's worth having aws-load-balancer-scheme set explicitly to internal.
Looking good otherwise. Gotta love how simple these things are in K8s.
mrliptontea
approved these changes
Jan 3, 2023
stephenrob
force-pushed
the
plat_5939_mongo_lb
branch
2 times, most recently
from
a93c931
to
dafd08b
Compare
stephenrob
force-pushed
the
plat_5939_mongo_lb
branch
from
dafd08b
to
d8c206a
Compare
|
🎉 This PR is included in version 2.33.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/talis/platform/issues/5939
Update the mongo construct to have optional parameter to expose the mongo service on an internal nlb allowing all internal traffic.