Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use standard python code formatter #171

Closed
dwiel opened this issue Jul 23, 2020 · 3 comments
Closed

use standard python code formatter #171

dwiel opened this issue Jul 23, 2020 · 3 comments

Comments

@dwiel
Copy link
Collaborator

dwiel commented Jul 23, 2020

Do you have thoughts on using a standard python code formatter like black? There are a few reasons for putting all python code through such a tool.

  1. Using a tool like black makes editing code by voice significantly easier. You can dictate code in a nasty format and with no spaces, etc. Once you are done, you can just let your editor/formatter fix everything for you with a single command or on every save
  2. It makes it easier to keep a codebase like this being edited by multiple people in the same style for easier reading and contributing

One issue with this tool is that if I start using it on my code, any PR I make will include all kinds of formatting changes as well which is undesirable. I would be happy to make a PR which runs the entire code base through such a formatter, just let me know.

@fidgetingbits
Copy link
Collaborator

I am using black at the moment for this same reason and basically anything I send pull requests for I just include the black changes. definitely be in favor of everyone moving to black :D

@knausj85
Copy link
Member

knausj85 commented Jul 23, 2020

yeah, this is a good call. I think fidget brought it up some time ago, and I forgot about it.

I'm fine with blackening all the things.

knausj85 added a commit that referenced this issue Jul 24, 2020
@dwiel
Copy link
Collaborator Author

dwiel commented Jul 24, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants