-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentence the air is fresh
produces "TheaIs fresh"
#299
Comments
|
IMO this is really one of the tradeoffs of anchoring the formatter. Without anchoring, something like I try to remember to use the "over" variant of the formatters for such cases, which is a decent compromise. I think fixing both is wise--at least a better default. |
For the moment, I've removed user.letter from formatters_immune since I can't it to work on the current beta with Dragon. |
Someone mentioned this in #beta today: https://talonvoice.slack.com/archives/G9YTMSZ2T/p1608050965475600. @dwiel also ran into a similar issue and mentioned it in #community.
There are really two issues here:
sentence
is a formatter, so it doesn't behave likesay|phrase
, which is unintuitive given its name. eg. Because of formatter chaining, for example,sentence the snake is here
becomes "Theis_here".Formatters permit letter names in them; see the formatter_immune capture, https://github.com/knausj85/knausj_talon/blob/master/code/formatters.py#L220. Thus
air
inthe air is fresh
gets interpreted as "a" and the formatter restarts. This also means thatsnake quick look
becomesquickl
instead ofquick_look
.I think we should at least fix 1. 2 has some genuine uses, but I would prefer hiding it behind a prefix so you have to say
snake quick spell look
to getquickl
; that might be less easy to trip over.The text was updated successfully, but these errors were encountered: