-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dictation not working on recent commits #922
Comments
It seems that this commit (2bafd31d) might be the cause since it seems to add the |
Reverting the commit mentioned above locally also solved the issue. Not that I'm suggesting that should be the fix here, only that this indicates that particular commit seems to be the cause. |
See also: Please remove pyupgrade from the knausj_talon process and revert any typing changes for now until I have official advice on this. In general, pyupgrade seems like it's a bad idea to run automatically on talon repos. Any syntax upgrades should be intentional and measured. |
We don't want pyupgrade: #922 We will add back individual formatters later.
We don't want pyupgrade: #922 We will add back individual formatters later.
This should be fixed now. If you could confirm it works for you that would be great. |
Thanks for the super quick fix. I can confirm that the latest main commit works for me. |
We don't want pyupgrade: talonhub#922 We will add back individual formatters later.
We don't want pyupgrade: talonhub/community#922 We will add back individual formatters later.
Commits after
b26bf15ee1fb0b5feb6846d6e8077d8ee6cc9028
on the main branch cause all dictation (say
command, formatters and dictation mode) to not work for me using Talon 0.3.0 on a Mac M1. Thetalon.log
file shows the following error when talon starts up. Checking out commitb26bf15ee1fb0b5feb6846d6e8077d8ee6cc9028
directly makes dictation work and does not show the error on startup but the (currently) three commits after that on main do not work for me.Note that another user has also reported seeing this on the Talon Slack chat (https://talonvoice.slack.com/archives/C7ENXA7C4/p1658075312159609?thread_ts=1658061197.879179&cid=C7ENXA7C4).
The text was updated successfully, but these errors were encountered: