Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch redundant sleep/wake commands, and notify the user that Talon is already in the requested mode #1327

Merged
merged 15 commits into from
Apr 6, 2024
Merged

Catch redundant sleep/wake commands, and notify the user that Talon is already in the requested mode #1327

merged 15 commits into from
Apr 6, 2024

Conversation

SkepticMystic
Copy link
Contributor

@SkepticMystic SkepticMystic commented Dec 7, 2023 •
edited by phillco
Loading

This commit adds some commands to catch redundant sleep/wake commands, and notifies the user.
The main example is, if Talon is already awake, the "talon wake" and "wake up" commands aren't active. So if the user is unsure of their current mode and says "wake up", Talon interprets the command as something else ("page up", for example).
These new commands are active in the mode the user is trying to activate. They catch the command, and trigger an app.notify to let the user know they're already in that mode.

Before #1215, these were bound with mode: all, so using them in the wrong mode would still be recognized, but just no-op.

phillco
phillco reviewed Dec 13, 2023
View reviewed changes
core/modes/modes.talon Outdated Show resolved Hide resolved
core/modes/sleep_mode.talon Outdated Show resolved Hide resolved
core/modes/modes.talon Outdated Show resolved Hide resolved
SkepticMystic and others added 3 commits December 13, 2023 21:14
@SkepticMystic @phillco
Merge new commands in core/modes/modes.talon
2471d08 
Co-authored-by: Phil Cohen <phillip@phillip.io>
@SkepticMystic @phillco
Merge new commands in core/modes/sleep_mode.talon
ee5e271 
Co-authored-by: Phil Cohen <phillip@phillip.io>
@SkepticMystic @phillco
Use better terminology in new comments in core/modes/modes.talon
d7d782a 
Co-authored-by: Phil Cohen <phillip@phillip.io>
@SkepticMystic
Copy link
Contributor Author

Thanks @phillco. I agree with your suggestions. I've commited the changes :)

phillco
phillco approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@phillco phillco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one more round of suggestions 😅

Overall, I think this is a nice change to help with the UX migration from the old behavior.

Simply re-adding these commands in the other modes would be fine too, but I actually like showing notification slightly better, since it tells the user that they're doing something they don't need to.

core/modes/modes.talon Outdated Show resolved Hide resolved
core/modes/modes.talon Outdated Show resolved Hide resolved
core/modes/sleep_mode.talon Outdated Show resolved Hide resolved
SkepticMystic and others added 3 commits December 14, 2023 08:02
@SkepticMystic @phillco
Clarify comment in core/modes/modes.talon
c823480 
Co-authored-by: Phil Cohen <phillip@phillip.io>
@SkepticMystic @phillco
Capitalise app.notify message
d86e351 
Co-authored-by: Phil Cohen <phillip@phillip.io>
@SkepticMystic @phillco
Capitalise app.notify message
90ead5c 
Co-authored-by: Phil Cohen <phillip@phillip.io>
knausj85 and others added 3 commits January 28, 2024 09:27
@knausj85
Move all sleep and wake commands ino common files
28d7966 
- consolidate commands specific to dragon (modes_dragon)
- consolidate commands specific to wav2letter (modes_not_dragon)
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
698a3b5 
for more information, see https://pre-commit.ci
@SkepticMystic
Merge branch 'talonhub:main' into catch-redundant-sleep-wake
238a5cc
pokey
pokey reviewed Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left some comments

core/modes/modes.py Outdated Show resolved Hide resolved
core/modes/modes_not_dragon.talon Outdated Show resolved Hide resolved
core/modes/modes_not_dragon.talon Show resolved Hide resolved
pokey
pokey reviewed Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one final comment

core/modes/modes_not_dragon.talon
Comment on lines +1 to +2
mode: sleep
not mode: sleep
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this saying "mode sleep or not mode sleep"? That is always true, right? Can't we just remove both of these lines?

Copy link
Member

@knausj85 knausj85 Feb 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without any modes specified, a talon file will be implicitly in command mode only. I don't think there's another way to accomplish this other than mode: all, which would be coming full circle

@knausj85 knausj85 merged commit de711f0 into talonhub:main Apr 6, 2024
2 checks passed
@SkepticMystic SkepticMystic deleted the catch-redundant-sleep-wake branch April 6, 2024 11:39
bhipple added a commit to bhipple/knausj_talon that referenced this pull request Apr 7, 2024
@bhipple
Revert "Catch redundant sleep/wake commands, and notify the user that…
5e4f33a 
… Talon is already in the requested mode (talonhub#1327)"

This reverts commit de711f0.
jaresty pushed a commit to jaresty/community that referenced this pull request Apr 15, 2024
@SkepticMystic @pre-commit-ci
@phillco @knausj85 @jaresty
Catch redundant sleep/wake commands, and notify the user that Talon i…
d87e3c2 
…s already in the requested mode (talonhub#1327)

This commit adds some commands to catch redundant sleep/wake commands,
and notifies the user.
The main example is, if Talon is already awake, the "talon wake" and
"wake up" commands aren't active. So if the user is unsure of their
current mode and says "wake up", Talon interprets the command as
something else ("page up", for example).
These new commands are active in the mode the user is trying to
activate. They catch the command, and trigger an `app.notify` to let the
user know they're already in that mode.

Before talonhub#1215, these were bound
with `mode: all`, so using them in the wrong mode would still be
recognized, but just no-op.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Phil Cohen <phillip@phillip.io>
Co-authored-by: Jeff Knaus <knaus.jeff@gmail.com>
@maxbruening maxbruening mentioned this pull request May 16, 2024
Open
emragins pushed a commit to emragins/talon-community that referenced this pull request May 28, 2024
@SkepticMystic @pre-commit-ci
@phillco @knausj85 @emragins
Catch redundant sleep/wake commands, and notify the user that Talon i…
6d75bc6 
…s already in the requested mode (talonhub#1327)

This commit adds some commands to catch redundant sleep/wake commands,
and notifies the user.
The main example is, if Talon is already awake, the "talon wake" and
"wake up" commands aren't active. So if the user is unsure of their
current mode and says "wake up", Talon interprets the command as
something else ("page up", for example).
These new commands are active in the mode the user is trying to
activate. They catch the command, and trigger an `app.notify` to let the
user know they're already in that mode.

Before talonhub#1215, these were bound
with `mode: all`, so using them in the wrong mode would still be
recognized, but just no-op.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Phil Cohen <phillip@phillip.io>
Co-authored-by: Jeff Knaus <knaus.jeff@gmail.com>
Mark-Phillipson added a commit to Mark-Phillipson/community that referenced this pull request Jul 22, 2024
@Mark-Phillipson
Squashed commit of the following:
aed1b77 
commit bcd6a64
Author: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Date:   Sun Jul 21 18:26:26 2024 +0200

    Refactor dragon engine (talonhub#1505)

    Fixes talonhub#1503

commit bed708a
Author: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Date:   Sun Jul 21 17:41:38 2024 +0200

    Use Talon screen ordering (talonhub#1502)

commit 7f2d601
Author: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Date:   Sun Jul 21 17:38:04 2024 +0200

    Made default noise implementations noop (talonhub#1500)

commit 9bf9a02
Author: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Date:   Sun Jul 21 17:32:09 2024 +0200

    Don't use mimic when not using dragon (talonhub#1504)

commit 5b43105
Author: Brad Majewski <80358359+bradmajewski@users.noreply.github.com>
Date:   Tue Jul 16 03:12:37 2024 -0400

    Fixing display of scroll mode for wheel gaze (talonhub#1485)

commit 9498ffc
Author: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Date:   Tue Jul 9 16:17:50 2024 +0200

    Unify go back and go forward implementations (talonhub#1490)

    This implements standardized go back and go forward voice commands as
    well as matching actions to be used in applications system wide

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

commit 2c18a5f
Author: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Date:   Sun Jul 7 19:10:40 2024 +0200

    Custom subtitles (talonhub#1467)

    Custom subtitles and notifications with settings to tweak color,
    position and timeout.

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Nicholas Riley <com-github@sabi.net>

commit ab63241
Author: Nicholas Riley <com-github@sabi.net>
Date:   Sat Jul 6 14:35:55 2024 -0400

    For help, consider any context with a match beginning with "app" application-specific. (talonhub#1481)

commit 63f33a6
Author: Adam Ambrosius <arambrosius@gmail.com>
Date:   Sat Jul 6 14:09:04 2024 -0400

    Added Warp App (talonhub#1472)

    Adds a basic configuration to be able to use the warp terminal the same
    as other terminal apps.

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

commit fb243a2
Author: David Vo <auscompgeek@users.noreply.github.com>
Date:   Sun Jul 7 01:57:06 2024 +1000

    file_manager: Check tag before querying current path (talonhub#1442)

    Also bugfix the clearing of the current page numbers.

commit 3d5e77d
Author: Schwa Aresty <jaresty@gmail.com>
Date:   Sat Jul 6 08:55:52 2024 -0700

    Allow formatting of abbreviations (talonhub#1427)

    - All abbreviations are currently lowercase
    - It is useful to be able to add them with formatting
    - This makes it possible

    ---------

    Co-authored-by: Nicholas Riley <com-github@sabi.net>
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

commit 73bb39e
Author: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Date:   Sat Jul 6 17:53:54 2024 +0200

    Added edit paragraph actions and commands (talonhub#1432)

    Co-authored-by: Nicholas Riley <com-github@sabi.net>

commit 4e4bfe8
Author: FireChickenProductivity <107892169+FireChickenProductivity@users.noreply.github.com>
Date:   Sat Jul 6 09:27:49 2024 -0600

    Add tag for disabling screenshots (Part of the Better Exam Support Project) (talonhub#1470)

    Add the tag user.disable_screenshots to make it easier for users to
    disable screenshot commands in certain circumstances. This was part of
    the project discussed in a community meeting to add built in
    functionality to community itself to make it easier to disable certain
    commands under specific circumstances, such as when taking an exam.

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

commit 772d51e
Author: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Date:   Sat Jul 6 11:07:01 2024 +0200

    Fix bug where you couldn't select help context by index (talonhub#1478)

    This broke in a recent update.

commit 0ceadc1
Author: Phil Cohen <phillip@phillip.io>
Date:   Fri Jul 5 10:55:25 2024 -0700

    functions: remove unused `setting_` module variables (talonhub#1475)

    A tiny cleanup in line with the recommendation I pushed to @CodesAway's
    talonhub#1474.

    With the move to `settings.get()`, we should no longer assign settings
    to module-level variables, since it's no longer needed, and we don't
    want anyone to use them by mistake. These aren't being used, so let's
    just remove them.

    This means you can now grep for `= mod.setting(` to search for old
    usages, and it comes up clean on main.

    (To my surprise, this code was using `settings.get()` from the beginning
    when @wenkokke wrote it)

commit a3fab3e
Author: Amy Brennan-Luna <codesaway@gmail.com>
Date:   Thu Jul 4 20:30:17 2024 -0500

    draft_talon_helpers: migrate away from deprecated settings usage (talonhub#1474)

    Fixed warning about using `setting.get()`
    Changed to use `settings.get(setting_name)`

    Closes talonhub#1473
    See also talonhub#1351,
    talonhub#1349

    ---------

    Co-authored-by: Phil Cohen <phillip@phillip.io>

commit dd52745
Author: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Date:   Mon Jul 1 18:05:43 2024 +0200

    Sort help contexts by specificity (talonhub#1460)

    Instead of just sorting the help context alphabetically we now first
    sort them by context match specificity. Context with equal specificity
    are sorted alphabetically.

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: David Vo <auscompgeek@users.noreply.github.com>
    Co-authored-by: Nicholas Riley <com-github@sabi.net>

commit fd17764
Author: Schwa Aresty <jaresty@gmail.com>
Date:   Mon Jul 1 02:12:38 2024 -0700

    Adds a helper to run tasks (talonhub#1414)

commit c495097
Author: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Date:   Sun Jun 30 03:48:47 2024 +0200

    Added mute/microphone disabled to mode indicator (talonhub#1466)

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Phil Cohen <phillip@phillip.io>

commit 6a25790
Author: Amy Brennan-Luna <codesaway@gmail.com>
Date:   Sat Jun 29 20:36:55 2024 -0500

    Update python.py (talonhub#1469)

    Added break / continue for statements (similar to other languages)

    Closes talonhub#1468

commit 5a97058
Author: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Date:   Mon Jun 24 10:56:22 2024 +0200

    Added notepad application context (talonhub#1464)

commit b337c21
Author: Schwa Aresty <jaresty@gmail.com>
Date:   Sat Jun 22 08:33:17 2024 -0700

    Adds a helper to format and paste (talonhub#1454)

    - for example try 'string paste' to paste something as a string

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

commit d91cf83
Author: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Date:   Sat Jun 22 17:31:06 2024 +0200

    Cancel any current phrase when Talon is waking (talonhub#1435)

    When Talon wakes we set a timestamp threshold. On the next command we
    will compare the phrase timestamp to the threshold and cancel any phrase
    started before wakeup. This is to prevent commands from being executed
    if the user wakes Talon using a noise or keypress.

    ---------

    Co-authored-by: Nicholas Riley <com-github@sabi.net>

commit 8a05482
Author: Colton Loftus <70598503+C-Loftus@users.noreply.github.com>
Date:   Sat Jun 22 04:08:59 2024 -0400

    Add a `help snip` command to list snippets currently in scope (talonhub#1462)

    Snippets are very powerful but there is no help menu for them currently.

    This PR adds a simple command to integrate snippets with `help_list`.
    The output of the following is as follows. While it is a bit verbose, it
    doesn't add any extra Python code and it may be helpful sometimes to
    know what snippet is being mapped to which spoken form if the spoken
    form is not clear/semantic for some reason.

    I placed the help command for snippets in the `help.talon` following the
    convention of other help commands.

    ![An image showing the output table of `help snip`. The left column is
    the underlying snippet title and the right is the spoken
    form.](https://github.com/talonhub/community/assets/70598503/f99b5c0d-bd43-42b4-a0eb-f681eab07a67)

commit 6f2fa2b
Author: maxbruening <56445556+maxbruening@users.noreply.github.com>
Date:   Mon Jun 17 18:52:47 2024 +0200

    tab clone in tag: user.tabs (talonhub#1457)

    I propose to allow users to also say "tab clone". This would make the
    command consistent with rango. This will become particularly useful
    once/if community has more applications/contexts that support the "tab
    duplicate" voice command. Background: I was planning on implementing the
    command for windows explorer.

    To enable compatibility with rango I also created a complementary pull
    request on that repository: [PR
    13](david-tejada/rango-talon#13)

commit 5fb2f7f
Author: Colton Loftus <70598503+C-Loftus@users.noreply.github.com>
Date:   Mon Jun 17 03:57:29 2024 -0400

    Use active list with help_list (talonhub#1461)

    Currently if the user uses `user.help_list()` and passes in a list with
    multiple implementations, the first list will always be chosen by virtue
    of the code using index `[0]`. However, it should show the currently
    active implementation by using `[-1]`. This is probably unintended
    behavior.

    Without this change, it is impossible to use `user.help_list` with the
    `user.snippet` list that is contextually overridden based on programming
    language type. I would like to add a `help snip` command and that would
    depend on this.

commit 93c9261
Author: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Date:   Thu Jun 13 14:08:34 2024 +0200

    Add speech timeout to settings file (talonhub#1459)

    This is such a common question people have. I definitely believe we
    should make it easier for them.

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

commit 39bed39
Author: Schwa Aresty <jaresty@gmail.com>
Date:   Mon Jun 10 03:12:08 2024 -0700

    Add then command from cursorless recommendations (talonhub#1394)

    The recommendation comes from
    [here](https://github.com/cursorless-dev/cursorless/wiki/Common-recommendations)

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Phil Cohen <phillip@phillip.io>

commit d1bc894
Author: Trillium S <Spiteless@gmail.com>
Date:   Thu Jun 6 17:15:21 2024 -0700

    feat: Add dark_mode option in settings (talonhub#1453)

    Just learned that dark_mode exists, would like to have an easier
    settings option for users.

commit 6fcd300
Author: maxbruening <56445556+maxbruening@users.noreply.github.com>
Date:   Thu Jun 6 02:32:15 2024 +0200

    stata support (talonhub#1401)

    Adds support for the stata language and application.

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

commit 47c2257
Author: Schwa Aresty <jaresty@gmail.com>
Date:   Mon Jun 3 17:25:21 2024 -0700

    Add helper to go to the middle of a line (talonhub#1424)

    Adds a line command `[go] line mid` which is similar to vim's `gm` command and
    moves the cursor to the middle of the line.

    ---------

    Co-authored-by: Nicholas Riley <com-github@sabi.net>
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

commit 235bba4
Author: Schwa Aresty <jaresty@gmail.com>
Date:   Mon Jun 3 05:07:10 2024 -0700

    Add vscode terminal helper (talonhub#1395)

    It makes sense that the VSCode terminal should behave like a terminal.
    There's also a corresponding setting that needs to be set in VSCode. cc:
    @pokey

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>

commit 43974b9
Author: Schwa Aresty <jaresty@gmail.com>
Date:   Sun Jun 2 07:41:56 2024 -0700

    Add menu choosing helper from pokey_talon (talonhub#1393)

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

commit 71ab00a
Author: David Vo <auscompgeek@users.noreply.github.com>
Date:   Mon Jun 3 00:38:09 2024 +1000

    Delete dead Windows-specific code (talonhub#1441)

commit 879ab2c
Author: Schwa Aresty <jaresty@gmail.com>
Date:   Sun Jun 2 07:32:59 2024 -0700

    Add space after Kotlin keywords so that you can chain in keyword commands (talonhub#1429)

    Co-authored-by: Nicholas Riley <com-github@sabi.net>

commit 5ebcea7
Author: maxbruening <56445556+maxbruening@users.noreply.github.com>
Date:   Sat Jun 1 04:54:47 2024 +0200

    Creates the "find" tag and removes that functionality from "find_and_replace" (talonhub#1404)

    The idea is to have a separate "find" tag for very basic search
    functionality. The reason is that there are many types of applications
    that are mostly view only (webbrowsers, pdf readers, etc.). These
    applications would not benefit from the full functionality of the
    "find_and_replace" tag.

    In order not to define some voice commands twice, I made the
    "find_and_replace" tag automatically activate the new "find" tag as well
    and removed what would have been duplicate definitions.

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Nicholas Riley <com-github@sabi.net>

commit 18c0aa4
Author: Michael Arntzenius <daekharel@gmail.com>
Date:   Sat Jun 1 03:46:41 2024 +0100

    More emacs commands, including xref commands (go-to-definition) (talonhub#1443)

    Adds more emacs commands, mostly `xref` commands but also `other-frame`
    and `visit-tags-table`. Also sorts `emacs_commands.csv`.

commit 15d4fdc
Author: Michael Arntzenius <daekharel@gmail.com>
Date:   Sun May 26 15:10:34 2024 +0100

    allow "help last" as synonym for "help previous" (talonhub#1444)

commit 98021b1
Author: David Vo <auscompgeek@users.noreply.github.com>
Date:   Sun May 26 18:17:19 2024 +1000

    imperative: Add `state match` alias for Python/Rust (talonhub#1440)

    In Python and Rust, we've implemented `code_state_switch()` to insert
    the `match` keyword. Give it that name too.

commit 86bb196
Author: Samuel Cole <cole.samuel21@gmail.com>
Date:   Mon May 13 12:02:26 2024 -0500

    Get vscode.py to recognize cursor IDE for macos (talonhub#1436)

commit 6ee7c72
Author: Nicholas Riley <com-github@sabi.net>
Date:   Sat May 11 13:23:35 2024 -0400

    Update talonfmt (talonhub#1434)

    Update the version of talonfmt to (hopefully) remedy the compatibility
    issue breaking CI.

    (refs talonhub#1430)

commit 027d7d0
Author: Michael Arntzenius <daekharel@gmail.com>
Date:   Tue Apr 23 18:54:13 2024 +0100

    micro-optimization for dictation_insert (talonhub#1422)

commit 23e371f
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Sun Apr 21 16:05:11 2024 -0400

    [pre-commit.ci] pre-commit autoupdate (talonhub#1417)

commit 1f3499a
Author: maxbruening <56445556+maxbruening@users.noreply.github.com>
Date:   Sun Apr 21 21:18:44 2024 +0200

    define "zoom reset" for VSCode (talonhub#1420)

    The default value for "zoom reset" defined in edit_win.py is "ctrl-0".
    This does not work in VS Code. The PR attempts to fix this.

commit eeb7a93
Author: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Date:   Tue Apr 16 16:07:17 2024 +0200

    Get snippets actions (talonhub#1315)

    Added actions to get insertion and wrapper snippet content(body, scope,
    etc). This will be used by example cursorless to leverage the community
    snippets

    Follow up from:
    talonhub#1305

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>

commit 801afdd
Author: Schwa Aresty <jaresty@gmail.com>
Date:   Sun Apr 14 18:45:51 2024 -0700

    Add basic kotlin support (talonhub#1408)

    - Borrowed from
    [here](okonomichiyaki@6542dc3)

    Addresses talonhub#1406

    ---------

    Co-authored-by: okonomichiyaki <74801510+okonomichiyaki@users.noreply.github.com>
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Jeff Knaus <knaus.jeff@gmail.com>

commit 93731ec
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Sun Apr 14 18:20:06 2024 -0400

    [pre-commit.ci] pre-commit autoupdate (talonhub#1413)

    <!--pre-commit.ci start-->
    updates:
    - [github.com/pre-commit/pre-commit-hooks: v4.5.0 →
    v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)
    <!--pre-commit.ci end-->

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

commit 5e1e579
Author: maxbruening <56445556+maxbruening@users.noreply.github.com>
Date:   Mon Apr 15 00:19:09 2024 +0200

    Support for Foxit Reader for PDFs (talonhub#1403)

    Adds basic support for the foxit reader on windows.

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Jeff Knaus <knaus.jeff@gmail.com>

commit 679bdfb
Author: maxbruening <56445556+maxbruening@users.noreply.github.com>
Date:   Sun Apr 14 21:32:01 2024 +0200

    Meld (talonhub#1402)

commit afb2246
Author: Schwa Aresty <jaresty@gmail.com>
Date:   Sun Apr 14 12:26:19 2024 -0700

    Add vscode command to search for views by name (talonhub#1390)

commit 4c1c9af
Author: Jeff Knaus <knaus.jeff@gmail.com>
Date:   Sat Apr 13 11:29:25 2024 -0400

    Talon v0.4 support: common commands for talon python / talon files / .talon-list files (talonhub#1240)

    Splitting talonhub#1234 into a few
    pull requests for convenience. This is not fully vetted yet, opening a
    draft for convenience and initial discussion.

    - Support for common commands when composing talon-list, .talon, and
    talon .py
    - Support for the talon debug window, with commands consistent with
    other existing commands

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Nicholas Riley <com-github@sabi.net>

commit 1464ace
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Sun Apr 7 00:10:44 2024 -0400

    [pre-commit.ci] pre-commit autoupdate (talonhub#1389)

    <!--pre-commit.ci start-->
    updates:
    - [github.com/psf/black-pre-commit-mirror: 24.1.1 →
    24.3.0](psf/black-pre-commit-mirror@24.1.1...24.3.0)
    - [github.com/Lucas-C/pre-commit-hooks: v1.5.4 →
    v1.5.5](Lucas-C/pre-commit-hooks@v1.5.4...v1.5.5)
    <!--pre-commit.ci end-->

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

commit 05f1d83
Author: Chris Hall <followingthepath@gmail.com>
Date:   Sat Apr 6 22:55:03 2024 +1100

    formatters: new conga formatter, renamed formatters for consistency. (talonhub#1355)

    previously:
     - SLASH_SEPARATED includes a prefix slash, unlike other *_SEPARATED.

    now:
     - renamed SLASH_SEPARATED to ALL_SLASHES
     - added new SLASH_SEPARATED matching *_SEPARATED behavior.
     - added new command `conga` (for 'conga line') for SLASH_SEPARATED.

commit 1ebc040
Author: Mikhail Menshchikov <65714995+mik-menshikov@users.noreply.github.com>
Date:   Sat Apr 6 13:53:49 2024 +0200

    Turning off listening mode after a timeout (talonhub#1320)

    Added a setting that allows to put Talon into Sleep mode automatically
    after a certain timeout expressed in minutes.
    On timeout the large notification "sleep mode" is shown at the center of
    the main screen to indicate mode change.

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Jeff Knaus <knaus.jeff@gmail.com>

commit de711f0
Author: Ross <70717676+SkepticMystic@users.noreply.github.com>
Date:   Sat Apr 6 13:35:52 2024 +0200

    Catch redundant sleep/wake commands, and notify the user that Talon is already in the requested mode (talonhub#1327)

    This commit adds some commands to catch redundant sleep/wake commands,
    and notifies the user.
    The main example is, if Talon is already awake, the "talon wake" and
    "wake up" commands aren't active. So if the user is unsure of their
    current mode and says "wake up", Talon interprets the command as
    something else ("page up", for example).
    These new commands are active in the mode the user is trying to
    activate. They catch the command, and trigger an `app.notify` to let the
    user know they're already in that mode.

    Before talonhub#1215, these were bound
    with `mode: all`, so using them in the wrong mode would still be
    recognized, but just no-op.

    ---------

    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Phil Cohen <phillip@phillip.io>
    Co-authored-by: Jeff Knaus <knaus.jeff@gmail.com>

commit aaa62f0
Author: timo <timonator@perpetuum-immobile.de>
Date:   Sun Mar 31 19:34:51 2024 +0200

    add lowercased firefox-esr to firefox.py (talonhub#1410)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey left review comments

@phillco phillco phillco approved these changes

@knausj85 knausj85 knausj85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SkepticMystic @phillco @pokey @knausj85