pre-commit: check in basic rules #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2022
auscompgeek
reviewed
Apr 3, 2022
purpleP
pushed a commit
to purpleP/knausj_talon
that referenced
this pull request
Jun 27, 2022
* pre-commit: check in basic rules * README: add pre-commit instructions * README: update set up instructions * change pre-commit hooks order * README: update update because pre-commit.ci is not yet installed on knausj * README: update Co-authored-by: Michael Arntzenius <daekharel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This begins the process of introducing automatic, required formatting as described in #816.
This PR just introduces the most minimum rules to start, which will apply to all files, including Talonscript:
mixed-line-ending(ensures consistent line endings, defaults to the most common in the repository)trailing-whitespace(trims trailing whitespace)end-of-file-fixer(every file should end with a newline)check-merge-conflict(blocks if merge conflict markers are present, indicating a bad merge)To avoid merge conflicts, this PR doesn't actually include the reformatting changes -- see this PR for what that would look like, but as described in #816, I think it'd be simplest if the maintainers just ran
pre-commit run --all-filesand pushed the fixes directly tomasterafter merging this.There would be a few extra steps needed by repository maintainers to add enforcement after this merges. Those are described in #816.