Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove build tags from integration binary #2606

Closed
wants to merge 1 commit into from

Conversation

andrewrynhard
Copy link
Member

This will make development of test much easier.

Signed-off-by: Andrew Rynhard andrew@rynhard.io

@andrewrynhard
Copy link
Member Author

/approve

@lgtm-com
Copy link

lgtm-com bot commented Oct 6, 2020

This pull request introduces 4 alerts when merging a4a8015 into 018086d - view on LGTM.com

new alerts:

  • 2 for Incomplete regular expression for hostnames
  • 2 for Missing regular expression anchor

This will make development of test much easier.

Signed-off-by: Andrew Rynhard <andrew@rynhard.io>
@lgtm-com
Copy link

lgtm-com bot commented Oct 6, 2020

This pull request introduces 4 alerts when merging 78602aa into 018086d - view on LGTM.com

new alerts:

  • 2 for Incomplete regular expression for hostnames
  • 2 for Missing regular expression anchor

@smira
Copy link
Member

smira commented Oct 6, 2020

{
    "go.buildTags": "integration,integration_api,integration_cli,integration_k8s",
    "gopls.env": {
        "GOFLAGS": "-tags=integration,integration_api,integration_cli,integration_k8s"
    }
}

this seems to fix the issue with gopls for me

@smira
Copy link
Member

smira commented Oct 6, 2020

link: golang/go#29202 (comment)

@smira
Copy link
Member

smira commented Oct 12, 2020

I wonder if we should fix the golangci-lint by pushing build tags (looks like it ignored the files?)

@andrewrynhard andrewrynhard added this to the v0.7 milestone Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants