Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a broad refactor.
I wanted to suggest this approach as I think it simplifies things a great deal and makes the functionality fully cacheable in a straight forward way.
Two major notes:
I did not implement adoption because I did not fully understand the distinction between
include
andadopt
.But, whatever it is, I think it could be added back with some conditional checks in the
WpEditorRemoveRules
plugin.I don't think my handling of AtRules edge cases is as thorough as yours. To be honest, I didn't want to have to deal with all the intricacies, I only wanted to prove the concept. The robustness of the existing approach could/should be added back in.
Feel free to re-implement it, add to it, ignore it. Thanks!