Skip to content

Commit

Permalink
Decrease complexity of function
Browse files Browse the repository at this point in the history
  • Loading branch information
talyssonoc committed Mar 21, 2019
1 parent a1c1fe0 commit 47ae676
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions src/initialization/initialization.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
const { ATTRIBUTES } = require('../symbols');
const initializationOrderFor = require('./initializationOrder');

function initializedValue(attrPassedValue, attrInitializer, attrDescriptor, instance) {
if(attrPassedValue !== undefined) {
return attrPassedValue;
}

return attrInitializer(attrDescriptor, instance);
}

module.exports = function forSchema(schema) {
const initializationOrder = initializationOrderFor(schema);

Expand All @@ -13,11 +21,7 @@ module.exports = function forSchema(schema) {
const attrDescriptor = schema[attrName];
const attrPassedValue = attributes[attrName];

if(attrPassedValue !== undefined) {
instance[attrName] = attrPassedValue;
} else {
instance[attrName] = attrInitializer(attrDescriptor, instance);
}
instance[attrName] = initializedValue(attrPassedValue, attrInitializer, attrDescriptor, instance);
}
}
};
Expand Down

0 comments on commit 47ae676

Please sign in to comment.