Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: don't change the object passed in the constructor #66

Conversation

tiagogoncalves89
Copy link

Now, the structure never change any data outside the library escope.

@tiagogoncalves89 tiagogoncalves89 changed the title bugfix - Don't change the object passed in the constructor bugfix: don't change the object passed in the constructor Jan 26, 2019
@wenderjean
Copy link
Collaborator

@tiagogoncalves89 Would you mind to elaborate better about the problem itself?

@talyssonoc
Copy link
Owner

@wenderjean I think what he meant is that, currently, we mutate the attributes object passed to the structure constructor.

@tiagogoncalves89 can you use object spread instead of Object.assign? Also do you think we could change the word "change" for "mutate" to make it use a more standard word?

@talyssonoc
Copy link
Owner

Closed by #77

@talyssonoc talyssonoc closed this Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants