Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added uuid validation to string type #76

Merged
merged 7 commits into from Feb 22, 2019

Conversation

talyssonoc
Copy link
Owner

Hey @tiagogoncalves89, I fixed what we suggested in the other PR and kept your commit, I hope you don't mind 馃槃

@wenderjean
Copy link
Collaborator

@talyssonoc Do you think we should support both guid and uuid since uuid is an alias for guid function on Joi?

https://github.com/hapijs/joi/blob/v14.3.1/API.md#stringguid---aliases-uuid

@talyssonoc
Copy link
Owner Author

talyssonoc commented Feb 22, 2019

@wenderjean I would avoid aliases like that so we don't have a 1-1 map to Joi, the idea is to keep it consistent. But maybe we should use just guid instead of uuid since uuid is the alias and guid is the original, what do you think?

As a follow up PR we could add the possibility to pass the version accepted.

@wenderjean
Copy link
Collaborator

I do agree we could use only guid because it automatically leades me to think in a generic version and sure, allow developers to set an specific version in a future feature will be great.

When we merge this one I'm going to open an issue to add version options.

wenderjean
wenderjean previously approved these changes Feb 22, 2019
@talyssonoc talyssonoc merged commit f46516c into master Feb 22, 2019
@talyssonoc talyssonoc deleted the added-uuid-validation-to-string-type branch February 22, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants