Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullable option to attributes #81

Conversation

wenderjean
Copy link
Collaborator

@wenderjean wenderjean commented Feb 26, 2019

The proposal from PR #67 has originated a refactoring on coercion modules (#80) and this new feature.

@wenderjean wenderjean self-assigned this Feb 26, 2019
@wenderjean wenderjean mentioned this pull request Feb 26, 2019
@wenderjean wenderjean added the WIP Being worked on by some of the contributors label Feb 26, 2019
@wenderjean wenderjean force-pushed the feature/add-nullable-option-to-attributes branch 3 times, most recently from 84266e1 to de7f7b3 Compare February 28, 2019 18:32
@wenderjean wenderjean removed the WIP Being worked on by some of the contributors label Feb 28, 2019
Copy link
Owner

@talyssonoc talyssonoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need add tests for dynamics cases too?

docs/schema-concept/nullable-attributes.md Outdated Show resolved Hide resolved
docs/schema-concept/nullable-attributes.md Outdated Show resolved Hide resolved
docs/schema-concept/nullable-attributes.md Outdated Show resolved Hide resolved
docs/schema-concept/nullable-attributes.md Outdated Show resolved Hide resolved
docs/schema-concept/nullable-attributes.md Outdated Show resolved Hide resolved
docs/schema-concept/nullable-attributes.md Outdated Show resolved Hide resolved
docs/schema-concept/nullable-attributes.md Outdated Show resolved Hide resolved
docs/schema-concept/nullable-attributes.md Show resolved Hide resolved
docs/serialization.md Show resolved Hide resolved
docs/schema-concept/nullable-attributes.md Outdated Show resolved Hide resolved
@wenderjean wenderjean force-pushed the feature/add-nullable-option-to-attributes branch 2 times, most recently from a28a390 to 426188b Compare February 28, 2019 20:22
docs/schema-concept/nullable-attributes.md Show resolved Hide resolved
docs/schema-concept/nullable-attributes.md Show resolved Hide resolved
test/unit/coercion/boolean.spec.js Show resolved Hide resolved
test/unit/coercion/date.spec.js Show resolved Hide resolved
test/unit/coercion/string.spec.js Show resolved Hide resolved
@wenderjean wenderjean force-pushed the feature/add-nullable-option-to-attributes branch from 83569c6 to 4f2650e Compare March 11, 2019 16:27
@wenderjean wenderjean force-pushed the feature/add-nullable-option-to-attributes branch from 2e9a508 to f918739 Compare March 26, 2019 00:24
@talyssonoc talyssonoc merged commit f42f451 into talyssonoc:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants