New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nullable option to attributes #81
Merged
talyssonoc
merged 8 commits into
talyssonoc:master
from
wenderjean:feature/add-nullable-option-to-attributes
Mar 26, 2019
Merged
Add nullable option to attributes #81
talyssonoc
merged 8 commits into
talyssonoc:master
from
wenderjean:feature/add-nullable-option-to-attributes
Mar 26, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wenderjean
force-pushed
the
feature/add-nullable-option-to-attributes
branch
3 times, most recently
from
February 28, 2019 18:32
84266e1
to
de7f7b3
Compare
talyssonoc
requested changes
Feb 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we need add tests for dynamics cases too?
wenderjean
force-pushed
the
feature/add-nullable-option-to-attributes
branch
2 times, most recently
from
February 28, 2019 20:22
a28a390
to
426188b
Compare
kostadriano
reviewed
Mar 1, 2019
talyssonoc
requested changes
Mar 8, 2019
wenderjean
force-pushed
the
feature/add-nullable-option-to-attributes
branch
from
March 11, 2019 16:27
83569c6
to
4f2650e
Compare
wenderjean
force-pushed
the
feature/add-nullable-option-to-attributes
branch
from
March 26, 2019 00:24
2e9a508
to
f918739
Compare
talyssonoc
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposal from PR #67 has originated a refactoring on
coercion
modules (#80) and this new feature.