Build strict mode implementation #91

VictorKunzler · 2019-07-01T19:35:45Z

Added a method to instantiate a structure in strict mode, if the instance is invalid, the method will throw an error

talyssonoc

What happens if a nested structure is invalid, will it throw? If not, should it? If yes, we need tests for that.

talyssonoc · 2019-07-02T00:49:26Z

src/attributes/decorator.js

+      return instance;
+    }
+
+    WrapperClass.buildStrictMode = buildStrictMode;


I think we call it just buildStrict, what do you think? The mode word doesn't add too much value to the name.

talyssonoc · 2019-07-02T00:52:45Z

test/unit/instanceAndUpdate.spec.js

@@ -139,6 +140,26 @@ describe('instantiating a structure', () => {
        expect(user.name).to.equal('Not the default');
      });
    });
+
+    describe('instanding a structure with buildStrictMode', () => {


Suggested change

describe('instanding a structure with buildStrictMode', () => {

describe('instantiating a structure with buildStrict', () => {

test/unit/instanceAndUpdate.spec.js

+      });
+
+      context('when object is valid', () => {
+        it('return a intance', () => {


…ibute function

talyssonoc · 2019-07-03T12:51:43Z

docs/build-strict/README.md

@@ -0,0 +1,24 @@
+# Build Strict
+
+To instantiate a structure and automatically throw an error if that is invalid, you can use the buildStrict function.


Suggested change

To instantiate a structure and automatically throw an error if that is invalid, you can use the buildStrict function.

To instantiate a structure that automatically throws an error if that is invalid, you can use the `buildStrict` method.

talyssonoc · 2019-07-03T12:52:26Z

docs/build-strict/README.md

@@ -0,0 +1,24 @@
+# Build Strict


Maybe we should call this file strict-mode and change the title to Strict mode as well since it's the title of the item in the sidebar, what do you think?

Change the file name or the folder name?

the folder, the file has to be README 😄

talyssonoc · 2019-07-03T12:53:01Z

docs/build-strict/README.md

+    age: Number
+})(class User {});
+
+var user = User.buildStrictMode({


Suggested change

var user = User.buildStrictMode({

var user = User.buildStrict({

talyssonoc · 2019-07-03T12:58:26Z

test/unit/instanceAndUpdate.spec.js

+        it('throw an error', () => {
+          expect(() => {
+            User.buildStrict();  
+          }).to.throw(Error, 'Invalid Attributes');  


I think we can make this test more detailed using the with.property assertion as well, like this:

expect(badFn).to.throw(TypeError).with.property('code', 42);

This is not the actual code we'd use in the test, I took this example from here https://www.chaijs.com/api/bdd/#method_throw. We could use it to test the details as well. What do you think?

talyssonoc · 2019-07-03T12:59:10Z

test/unit/instanceAndUpdate.spec.js

+            })
+          });
+
+        }).to.throw(Error, 'Invalid Attributes');


Same thing here about using the with.property assertion.

kostadriano · 2019-07-08T18:37:13Z

docs/SUMMARY.md

@@ -16,10 +16,11 @@
  * [Number validations](validation/number-validations.md)
  * [Boolean validations](validation/boolean-validations.md)
  * [Date validations](validation/date-validations.md)
-  * [Array validations](validation/array-validations.md)
+  * [Array validations](validation/array-validations.md)m


typo here

Suggested change

* [Array validations](validation/array-validations.md)m

* [Array validations](validation/array-validations.md)

talyssonoc · 2019-07-08T18:41:50Z

src/attributes/decorator.js

+    function buildStrict(constructorArgs){
+      let instance = new WrapperClass(constructorArgs);
+
+      let {valid, errors} = instance.validate();


You can use const here and on line 32 as well.

kostadriano · 2019-07-08T18:44:34Z

test/unit/instanceAndUpdate.spec.js

+        }];
+
+        expect(() => {
+


VictorKunzler added 2 commits July 1, 2019 16:18

Add buildStrictMode method

d41dfeb

Add tests to buildStrictMode method

4d4814a

VictorKunzler force-pushed the buildStrictMode-implementation branch from 5c05eb9 to 4d4814a Compare July 1, 2019 21:04

Remove semicolon and user variable

fa33354

talyssonoc requested changes Jul 2, 2019

View reviewed changes

VictorKunzler added 4 commits July 2, 2019 14:10

Refactoring buildStrictMode to buildStrict and add Errors.invalidAttr…

5c4c679

…ibute function

Add tests to buildStrict when structure has custom types

2d5c759

Adjust to codeClimate

e928abb

Add docs for buildStrict

aac8ef5

talyssonoc requested changes Jul 3, 2019

View reviewed changes

VictorKunzler added 3 commits July 5, 2019 09:49

Adjust build-strict docs

f29aec7

Adjust build-strict docs

6c30725

Improve buildStrict tests

1c9fc28

kostadriano reviewed Jul 8, 2019

View reviewed changes

talyssonoc reviewed Jul 8, 2019

View reviewed changes

kostadriano reviewed Jul 8, 2019

View reviewed changes

test/unit/instanceAndUpdate.spec.js Outdated

}];

expect(() => {

Copy link

Collaborator

kostadriano Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

kostadriano previously approved these changes Jul 8, 2019

View reviewed changes

VictorKunzler added 2 commits July 8, 2019 16:28

Adjust typo

8849ae3

Change let for const

b833160

VictorKunzler dismissed kostadriano’s stale review via b833160 July 8, 2019 19:50

talyssonoc previously approved these changes Jul 8, 2019

View reviewed changes

Change the strict-mode docs path

1c33741

VictorKunzler dismissed talyssonoc’s stale review via 1c33741 July 8, 2019 20:24

talyssonoc approved these changes Jul 8, 2019

View reviewed changes

talyssonoc closed this Jul 8, 2019

talyssonoc reopened this Jul 8, 2019

talyssonoc merged commit f254c0d into talyssonoc:master Jul 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build strict mode implementation #91

Build strict mode implementation #91

VictorKunzler commented Jul 1, 2019

talyssonoc left a comment

talyssonoc Jul 2, 2019

talyssonoc Jul 2, 2019

This comment was marked as resolved.

talyssonoc Jul 3, 2019

talyssonoc Jul 3, 2019

VictorKunzler Jul 3, 2019 •

edited

Loading

talyssonoc Jul 4, 2019

talyssonoc Jul 3, 2019

talyssonoc Jul 3, 2019

talyssonoc Jul 3, 2019

kostadriano Jul 8, 2019

talyssonoc Jul 8, 2019

kostadriano Jul 8, 2019

	describe('instanding a structure with buildStrictMode', () => {
	describe('instantiating a structure with buildStrict', () => {

		@@ -0,0 +1,24 @@
		# Build Strict

		To instantiate a structure and automatically throw an error if that is invalid, you can use the buildStrict function.

	To instantiate a structure and automatically throw an error if that is invalid, you can use the buildStrict function.
	To instantiate a structure that automatically throws an error if that is invalid, you can use the `buildStrict` method.

	var user = User.buildStrictMode({
	var user = User.buildStrict({

	* [Array validations](validation/array-validations.md)m
	* [Array validations](validation/array-validations.md)

Build strict mode implementation #91

Build strict mode implementation #91

Conversation

VictorKunzler commented Jul 1, 2019

talyssonoc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VictorKunzler Jul 3, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VictorKunzler Jul 3, 2019 •

edited

Loading