Merge 8561523 into 1a90167

pom.xml

@@ -237,16 +237,12 @@
       </plugin>
 
       <plugin>
-        <groupId>org.codehaus.mojo</groupId>
-        <artifactId>findbugs-maven-plugin</artifactId>
-        <version>3.0.1</version>
+        <groupId>com.github.spotbugs</groupId>
+        <artifactId>spotbugs-maven-plugin</artifactId>
+        <version>3.1.0-RC8</version>
         <configuration>
           <inputEncoding>utf-8</inputEncoding>
           <outputEncoding>utf-8</outputEncoding>
-          <xmlOutput>true</xmlOutput>
-          <xmlOutputDirectory>target</xmlOutputDirectory>
-          <findbugsXmlOutput>true</findbugsXmlOutput>
-          <findbugsXmlOutputDirectory>target</findbugsXmlOutputDirectory>
         </configuration>
       </plugin>
 

src/main/java/com/github/ninerules/Main.java

@@ -1,6 +1,8 @@
 package com.github.ninerules;
 
 import java.io.PrintWriter;
+import java.io.OutputStreamWriter;
+import java.io.UnsupportedEncodingException;
 import java.nio.file.Path;
 import java.util.List;
 import java.util.stream.Collectors;
@@ -41,8 +43,8 @@ private Stream<Path> listupTargets(Stream<Argument> stream, Traverser traverser)
                 .flatMap(traverser::stream);
     }
 
-    public static void main(String[] args){
-        try(PrintWriter out = new PrintWriter(System.out)){
+    public static void main(String[] args) throws UnsupportedEncodingException {
+        try(PrintWriter out = new PrintWriter(new OutputStreamWriter(System.out, "utf-8"))){
             new Main(args, out);
         }
     }

src/main/java/com/github/ninerules/parameters/NullParameter.java

@@ -32,7 +32,7 @@ public boolean isGreaterThan(Parameter parameter) {
 
     @Override
     public boolean equals(Object object){
-        return object == parameter();
+        return this == object;
     }
 
     @Override

src/main/java/com/github/ninerules/parameters/ParameterComparator.java

@@ -1,8 +1,11 @@
 package com.github.ninerules.parameters;
 
+import java.io.Serializable;
 import java.util.Comparator;
 
-public class ParameterComparator implements Comparator<Parameter>{
+public class ParameterComparator implements Comparator<Parameter>, Serializable{
+    private static final long serialVersionUID = 3372664484116875247L;
+
     @Override
     public int compare(Parameter o1, Parameter o2) {
         PredicateHelper<Parameter, Integer> helper = buildHelper();