-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Update packages & run app and pages directories in parallel #23
Conversation
Hey @jonsherrard thanks for looking into this so quickly! Everything looks good to me. The only thing I'd note is that it'd be great to have the toast working on all platforms (I understand this might not be directly related to this PR). On the T4 stack starter they have built a toast that works both on web and on mobile: TBH I'm quite new to Tamagui and Expo so I don't quite understand what the difference is between the two starters |
@natew I also have an update here that I think would make the starter more approachable. It probably needs a note on watching and building the |
@jonsherrard another fun one: For example, instead of: On my project I do: With this I avoid the "cd'ing"into directories which might be confusing and run next and the tamagui ui scripts in parallel. Just a suggestion because there's already a turbo.json on the starter |
Huge, thanks for this amazing work. Once I get a chance I'll test this out and get it merged. I know we need to revisit RSC and improve a few things too. |
Awesome. One thing that will need updating is the Expo side. I tried to give it a go, but Expo is totally broken on my laptop at the minute and I totally ran out of time. I can't even It should just be a case of fetching the [id] from createParams in new Solito 4 world and passing it to the screen. Also let me know thoughts on jonsherrard#1 - if it's useful I can raise another PR |
- toast works in app, pages & expo
- fixed theme className hydration error - fixed SwitchThemeButton hydration errors - made switching from app to pages much easier
Addresses some of the concerns in tamagui/tamagui#2589
Updates to latest Next 14
Updates to Solito 4
Updates packages in general
Runs App Directory Routes AND Pages Directory routes in parallel
Crucially switches to using app directory as the default