Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does TamaGUI has so big slowdown in performance? #2678

Closed
NDruce opened this issue May 25, 2024 · 4 comments
Closed

Why does TamaGUI has so big slowdown in performance? #2678

NDruce opened this issue May 25, 2024 · 4 comments

Comments

@NDruce
Copy link

NDruce commented May 25, 2024

Current Behavior

Look on benchmarks:
https://github.com/efstathiosntonas/react-native-style-libraries-benchmark

Expected Behavior

No response

Tamagui Version

Idk

Platform (Web, iOS, Android)

Idk

Reproduction

Look the link I provided above

System Info

No response

@NDruce
Copy link
Author

NDruce commented May 25, 2024

Why just not build classes into native way in build time instead of runtime? It should remove any kind of performance impacts at all

@natew
Copy link
Member

natew commented Jul 28, 2024

CleanShot 2024-07-28 at 11 03 57@2x

@natew natew closed this as completed Jul 28, 2024
@natew
Copy link
Member

natew commented Jul 28, 2024

It can actually be significantly faster than hand-written, because compiler can flatten to ideal code, and also flattens to RCTView rather than View.

As usual, benchmarks are usually misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants