Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ListItem): add new composition api #2443

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ehxxn
Copy link
Member

@ehxxn ehxxn commented Mar 14, 2024

  • implementation
  • doc

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 3:01pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio ⬜️ Ignored (Inspect) May 2, 2024 3:01pm

@natew
Copy link
Member

natew commented Mar 19, 2024

a few things:

  1. your variants were missing as const, fixed one
  2. we should have unstyled prop for everything that passes through context
  3. the Button does this but i think its done differently
  4. if were doing this change, we should also do the headless conversion!

@ehxxn
Copy link
Member Author

ehxxn commented Mar 19, 2024

ok thanks, I'll fix those

@ehxxn ehxxn mentioned this pull request Mar 20, 2024
@ehxxn
Copy link
Member Author

ehxxn commented May 2, 2024

@natew docs will be available with another PR

## Anatomy

```tsx
import { Card } from 'tamagui' // or '@tamagui/card'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants