Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(components): document need for PortalProvider #2540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ehxxn
Copy link
Member

@ehxxn ehxxn commented Apr 16, 2024

No description provided.

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 3:56pm
studio 🔄 Building (Inspect) Visit Preview Apr 16, 2024 3:56pm

@natew
Copy link
Member

natew commented Apr 17, 2024

Lets make this a bit friendlier. Lets move it to an install section (if they don't have it lets make it consistent).

No need for any Notice I think just text "In order to use this component independently of tamagui, you'll need to add a provider to the root of your app:" and then a code block of the import + usage example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants