Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tamarin-prover-export #635

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

arcz
Copy link
Contributor

@arcz arcz commented May 23, 2024

Same as #621 but for the export part.
Is there a reason for it being a separate package? It's just two files, it would be easier to maintain if it was just part of the main package.

@rkunnema
Copy link
Member

Hi!

@yavivanov is introducing substantial changes to Export.hs at the moment, so I would keep this PR on hold until I get confirmation from him how well this can merge with this (functional) changes. Maybe it is better to apply the linter again after merge.

For some choice I am unsure: substituting pure for return (discussion at https://stackoverflow.com/questions/32788082/difference-between-return-and-pure). So I'd prioritize a smooth merge over a uniform use of one or the other.

Finally, export is in a separate package because it enforces better encapsulation. Moreover, Export.hs has now reached the size where it ought to be split into several files. I don't see much of a downside to it.

@arcz
Copy link
Contributor Author

arcz commented Jun 20, 2024

No problem, feel free to merge whatever you need I'll just rebase after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants