Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unuseful aes file #656

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Mathias-AURAND
Copy link
Contributor

I propose to remove the unuseful aes file, which is automatically created when we launch the app

@rkunnema
Copy link
Member

Wow, this was possible? Amazing! 😮 Do we lose anything here? A quick query to google gives:

https://www.yesodweb.com/book/sessions

By default, your Yesod application will use clientsession for its session storage, getting the encryption key from the client client-session-key.aes and giving a session a two hour timeout. [..]
One simple way to override this method is to simply turn off session handling; to do so, return Nothing. If your app has absolutely no session needs, disabling them can give a bit of a performance increase. But be careful about disabling sessions: this will also disable such features as Cross-Site Request Forgery protection.

Are we using sessions? Is CSRF something we try to protect against?

@jdreier
Copy link
Member

jdreier commented Jun 27, 2024

Since we are only running locally, I think we do not care about CSRF. Since the creation of the aes file sometimes causes problems, the idea is to avoid creating it. But if this causes other issues, please let us know.

@rkunnema
Copy link
Member

CSRF could come from another website trying to get your tamarin instance to do ... something? I think you can only get it to perform valid proofs and the oracles are trusted when you start the server, though.

@cascremers
Copy link
Member

We do need to think about the case where Tamarin is run on a remote server. I don't see an immediate problem but we should think this through properly.

@jdreier
Copy link
Member

jdreier commented Jul 16, 2024

We had some offline discussions, it seems that in our situation this can be acceptable. Merging. Solves #603

@jdreier jdreier merged commit cbfe6c4 into tamarin-prover:develop Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants