Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search overloads that take in CancellationToken #18

Closed
jochenvanwylick opened this issue Sep 21, 2015 · 2 comments
Closed

Add search overloads that take in CancellationToken #18

jochenvanwylick opened this issue Sep 21, 2015 · 2 comments

Comments

@jochenvanwylick
Copy link
Contributor

Once a search is fired off - there is no way to cancel the search process. I would suggest we add an overload to the search methods that takes in a cancellation token - which will stop the polling process in the background.

We're seeing a bunch of users that fire off wrong searches or decide to change their search mid-search. In order to save resources - I would like to be able to cancel the process.

Something along the lines of

Task<List<Itinerary>> QueryFlight(FlightQuerySettings flightQuerySettings, CancellationToken token);

@tamasvajk
Copy link
Owner

Good idea @jochenvanwylick.

Off:
Sorry I was not too responsive lately on the other open issues. I owe you at least one fix for two weeks now. I'm on my way of implementing these.

@jochenvanwylick
Copy link
Contributor Author

@tamasvajk No worries !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants