Fix presence of reflection in DB adapters #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamizhvendan
approved these changes
Nov 21, 2023
|
@dekelpilli Thanks again. The changes are available now in version |
|
@tamizhvendan thanks for getting that in so quickly! Unfortunately we're currently using/experimenting with this library in a closed-source application, but there are good resources for using adjacent tools with graalvm (honeysql + next.jdbc, postgres, Hikari. With these changes in 1.0.1, I believe these should be sufficient, as this library will no longer require additional Graal-specific configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding type hints to avoid reflection, which causes issues with Graal builds, as well as general performance issues.