New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Files #108
Add Files #108
Conversation
src/library/files/store.ts
Outdated
|
||
export const useFilesStore = defineStore('files', { | ||
state: () => ({ | ||
pathID: localStorage.getItem('files_path') || '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this state should be stored as URL param instead of localstorage/pinia store, otherwise it breaks browser history. There is no need to use as store at all when it's only used by as single component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not use browser history for navigation, we have all navigation elements on the page. But if you want, I can change it. But then I will add this option to client settings, because it very useful for me.
I've been testing this locally and it works pretty nicely. Features it's missing that I'd like to see someday:
I don't think any of those should be blockers for merging it, though. |
Just realized it also doesn't show metadata -- just filenames. |
Correct, it's not shows meta data, only filenames, it's not a mistake, if you need metadata you can add files to playlist and play it or get tracks from collection. My library building on filenames (on many files metadata are not correct or empty, but filenames are correct). Now I preparing client settings for Airsonic refix and when (if) files commit will be merged, I can add this (show meta information on Playing section) to the client settings. |
In my case the tags are usually correct, they just aren't sufficient in themselves for useful navigation (the directory tree is generated partially from data that lives outside the tags). The exception is generally files that don't support ID3 or Vorbis tags at all, like most tracker formats. Anyways, I've hacked file metadata display into my local version; it's really messy -- first time working in typescript -- but it seems to be working ok. I think that's sufficient that I can deploy it on my server while I wait for official support. Thank you for writing this! |
What's the plan with xonic-ui? |
I have a many plans for xonic-ui:
I wanted make it in airsonic-refix, but owner of this repo do not need it. I was starts all new branches from airsonic-refix master branch (for do not makes a conflict), but at the moment it was have many incompatible changes. I can't add new features, because old do not merged, and I makes a decision to make a fork. If you want to test or help, welcome. PS If you need a files in airsonic-refix, code available on |
@tamland Sorry bro, I was wrong, when you close radio stations I was think you do not need any new features to your repo and I make a fork. My bad. Only on last week I saw, you apply the Radio Stations changes. But it was very slow. I can't make a new, because many old code not merged. You can reopen any my PR and get features which you want, if you need. |
I have many music collections in folders and I like my structure of music. That's why I add files browser.