Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple album artists #115

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

sentriz
Copy link
Contributor

@sentriz sentriz commented Sep 10, 2023

hey, we are closing in on a design for album that have multiple artists at @opensubsonic opensubsonic/open-subsonic-api#8 (reply in thread)

this adds support for that, with fallback to previous behaviour if it's not supported

outw.webm

@sentriz sentriz changed the title Add support for multiple artists Add support for multiple album artists Sep 10, 2023
return out
},
}
</script>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just duplicate this code where needed. It's 1 additional line compared to the <Seperate> component. (Render function components are not optimizable or compatible with vue3 and should therefore be avoided)

Suggested change
</script>
<template v-for="(artist, index) in item.artists">
<template v-if="index > 0">, </template>
<router-link :key="artist.id" :to="{name: 'artist', params: { id: artist.id }}" class="text-muted">
{{ artist.name }}
</router-link>
</template>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sure, updated 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update again: just made the comma text-muted instead of the artist name

@sentriz sentriz force-pushed the master branch 3 times, most recently from c3d71c3 to a624079 Compare September 11, 2023 17:40
@tamland tamland merged commit f894d5e into tamland:master Sep 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants