Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw vertical or horizontal lines on plots #27

Closed
acarl005 opened this issue Oct 8, 2019 · 4 comments
Closed

Draw vertical or horizontal lines on plots #27

acarl005 opened this issue Oct 8, 2019 · 4 comments

Comments

@acarl005
Copy link
Contributor

acarl005 commented Oct 8, 2019

Drawing arbitrary vertical or horizontal lines on plot (scatter plots or histograms) is generally very useful, something analogous to this in matplotlib.

@tammoippen
Copy link
Owner

Hello @acarl005, thanks for the suggestion. I think they can easily be implemented in Figure by adding a methods, that use the plot function with two coordinates in X and Y, respectively. Are you interested in providing a PR? Otherwise I will look into this, but it might take some weeks for me to find the time.

@acarl005
Copy link
Contributor Author

For the API, what did you have in mind? If I wanted to create a vertical line at x = 5, maybe something like fig.plot(X=5) where Y argument is omitted?

@tammoippen
Copy link
Owner

tammoippen commented Oct 18, 2019

I think, i would prefer a new function for each, vlines(x) and hlines(y), as close as possible to https://matplotlib.org/3.1.0/api/_as_gen/matplotlib.axes.Axes.vlines.html#matplotlib.axes.Axes.vlines

tammoippen added a commit that referenced this issue Jun 30, 2021
@tammoippen
Copy link
Owner

Implemented in #38. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants