Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formコンポーネントを作成 #6

Merged
merged 2 commits into from
Oct 9, 2018
Merged

Formコンポーネントを作成 #6

merged 2 commits into from
Oct 9, 2018

Conversation

wakuwaku3
Copy link
Collaborator

@wakuwaku3 wakuwaku3 commented Sep 30, 2018

No description provided.

@wakuwaku3 wakuwaku3 changed the base branch from dev-dark-theme to master October 7, 2018 17:08
Copy link
Collaborator

@cookie1234 cookie1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mimasita!

const styles = createStyles({
root: {},
});
export interface FormProps {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

インターフェースだけど I はつけない感じです?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cookie1234
このあたりで I つけるなって書いてます…
microsoft/TypeScript-Handbook#121
https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines
ただServiceでは名前がかぶるのでやむをえず I つけてたりします。

@wakuwaku3 wakuwaku3 merged commit b187c3c into master Oct 9, 2018
@wakuwaku3 wakuwaku3 deleted the dev-form branch October 9, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants