Config branch #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
mainbranch strategy ofecho "${{ steps.apply.outputs.stdout }}" >> apply.loginadvertently escapes string sequences in the Terraform printout standard output (of which there are plenty). Any bash-unsafe characters are open to shell interpretation inside strings, causing the potential for syntax errors at best and shell injection at worst.This introduces the
teecommand to simultaneously print the standard output/standard error and write to an apply.log file, rather than print the output >> append to file in future steps.This PR also includes the change to the GitHub comment that removes the noisy "refreshing state/reading data source/read complete after" portions of the Terraform printout(still preserved in the apply.log), which helps with comment readability and, in some cases (for larger statefiles), comment size.