A few minor portability fixes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On BSDs including malloc.h causes a warning/error while on GNU systems
it provides malloc(3) extensions but not of _mm-type which are specific
to compiler.
/usr/include/malloc.h:3:2: error: "<malloc.h> has been replaced by <stdlib.h>"
#error "<malloc.h> has been replaced by <stdlib.h>"
^
i386 without -march or -msse can hit another issue:
src/Buffer.hpp:147:13: error: use of undeclared identifier '_mm_free'
_mm_free(host_ptr);
^
src/Buffer.hpp:282:24: error: use of undeclared identifier '_mm_malloc'
host_ptr = _mm_malloc(byte_size, 64);
^
src/Buffer.hpp:314:24: error: use of undeclared identifier '_mm_malloc'
host_ptr = _mm_malloc(byte_size, 64);
^
src/Buffer.hpp:325:24: error: use of undeclared identifier '_mm_malloc'
host_ptr = _mm_malloc(byte_size, 64);
^
4 errors generated.
ThreadPool is only implemented on Windows and Linux. Trying to build on
a BSD descendant ends up with:
In file included from src/Buffer.hpp:14:
src/threadPool.hpp:26:19: error: unknown type name
'event_t'
void notify_event(event_t ev);
^
src/threadPool.hpp:27:1: error: unknown type name 'event_t'
event_t create_event(void);
^
src/threadPool.hpp:28:19: error: unknown type name
'event_t'
void delete_event(event_t ev);
^
src/threadPool.hpp:29:19: error: unknown type name
'event_t'
void notify_event(event_t ev);
^
src/threadPool.hpp:66:2: error: unknown type name 'event_t'
event_t to_client;
^
src/threadPool.hpp:92:2: error: unknown type name 'event_t'
event_t to_master;
^
6 errors generated.
Open
tanakamura
added a commit
that referenced
this pull request
Sep 30, 2015
A few minor portability fixes
|
+1 tested build via DPorts automation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on FreeBSD 9.3-11.0 i386/amd64.