Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistancy in filtering cell type in annotation page #41

Closed
drorbar opened this issue Aug 12, 2021 · 1 comment · Fixed by #43
Closed

Inconsistancy in filtering cell type in annotation page #41

drorbar opened this issue Aug 12, 2021 · 1 comment · Fixed by #43
Labels
bug Something isn't working

Comments

@drorbar
Copy link
Contributor

drorbar commented Aug 12, 2021

At least, I think it's a bug.
If you go to the annotation page, and you filter out a cell type (by clicking on the gene projections legend), this cell type will disappear from the manifold and from the gene-gene plot -> this makes sense.
If now you choose a group of cells and change their annotation the filtering reset -> this was talked here: "#36"
On the other hand, if you change the chosen genes, those cells will reappear in the gene-gene plot but not in the gene projection. To remove those cell types in the gene-gene plot, you need to return them in the manifold and then filter them out again.
I guess this is happening because those two graphs aren't strongly linked in the objects they show, but the fact that when originally filtering out, they are connected, but after a change, they sometimes are and sometimes aren't is a bit weird .

@drorbar drorbar added the bug Something isn't working label Aug 12, 2021
aviezerl added a commit that referenced this issue Aug 19, 2021
* added refresh_on_gene_change parameter to render_2d_plotly, fixes #41

* cosmetics
@aviezerl
Copy link
Contributor

The coupling of the gene/gene plot and the projection plots is done using plotly events, and indeed it is not connected to the general shiny dependency structure, see:

connect_gene_plots <- function(input, output, session, ns, source) {

I do not know an easy way to identify that the visibility state of the projection has changed, so I fixed it by artificially connect ing the projection and the gene plot using shiny reactivity. Note that this means that the projection plot would be re-rendered any time the gene is changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants